Skip to content

Support for custom authentication provider#243

Closed
PierreSchwang wants to merge 7 commits intoelecterious:developfrom
PierreSchwang:master
Closed

Support for custom authentication provider#243
PierreSchwang wants to merge 7 commits intoelecterious:developfrom
PierreSchwang:master

Conversation

@PierreSchwang
Copy link
Copy Markdown

Implement support as described in #240

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 19, 2021

@PierreSchwang is attempting to deploy a commit to a Personal Account owned by @electerious on Vercel.

@electerious first needs to authorize it.

@PierreSchwang PierreSchwang changed the base branch from master to develop March 19, 2021 23:23
@PierreSchwang
Copy link
Copy Markdown
Author

I'm unsure right now, theoretically it would work, but since the /api endpoint for ackee-tracker has to be public, doesn't that also mean that the GraphQL query to retrieve stats is now public as well? I don't know how to solve this at all....

@electerious
Copy link
Copy Markdown
Owner

@PierreSchwang How are you protecting the UI of Ackee? Isn't it possible to protect the API in the same way?

@PierreSchwang
Copy link
Copy Markdown
Author

Yeah, but does the api not get used by the ackee script?

@electerious
Copy link
Copy Markdown
Owner

That's true. Not sure if there's a way to get around this problem. It's a GraphQL API so the endpoint for both ackee-tracker and Ackee is the same. This makes it impossible to allow ackee-tracker requests only.

@PierreSchwang
Copy link
Copy Markdown
Author

Yeah, thats what i thought. I may take a further look into that

@electerious
Copy link
Copy Markdown
Owner

I will close the PR as there's currently no solution to solve the authentication problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants